Do not create PeerHealth new client without credentials #155
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@clobrano: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test 4.14-openshift-e2e |
Currently if peerhealth.NewClient is called with no credentials.TransportCredentials it uses a DialOption which disables transport security for this ClientConn. Considering also the in the current code base it is not possible to reach this point without valid credentials, this commit removes the usage of such DialOption and returns with error instead for security reasons. Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
avoid_peerhealth_client_with_no_credentials/0
branch
from
63cd715
to
247562e
Compare
|
/lgtm |
|
/lgtm |
Currently if peerhealth.NewClient is called with no
credentials.TransportCredentials it uses a DialOption which disables
transport security for this ClientConn.
Considering also the in the current code base it is not possible to
reach this point without valid credentials, this commit removes the
usage of such DialOption and returns with error instead for security
reasons.