remove VA deletion

[mshitrit]

ECOPROJECT-1748
VA should not be deleted by SNR. kube-control-manager (KCM) detects the pod deletion and automatically detaches the VAs which are not connected to any pod, forcefully deleting the VA has the risk of interfering with the process of detaching the VAs.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mshitrit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mshitrit]

/test 4.12-openshift-e2e

[razo7]

Would it make more sense to move deleteResources function into the common repo, then FAR and SNR can use it as well for resource deletion?

[mshitrit]

Would it make more sense to move deleteResources function into the common repo, then FAR and SNR can use it as well for resource deletion?

I have no strong opinion either way.
On the one hand it's always a good thing avoiding code duplication but on the other hand I am not sure the overhead will be worth the value (specifically because it's a pretty short method).

[mshitrit]

/test 4.12-openshift-e2e

[razo7]

Would it make more sense to move deleteResources function into the common repo, then FAR and SNR can use it as well for resource deletion?

I have no strong opinion either way. On the one hand it's always a good thing avoiding code duplication but on the other hand I am not sure the overhead will be worth the value (specifically because it's a pretty short method).

Can you update commons and use DeletePods from https://github.com/medik8s/common/releases/tag/v1.9.0? Other than that looks good for me.

[clobrano]

/lgtm

Just leaving the time to close the other threads
/hold

[mshitrit]

/unhold

[mshitrit]

/hold

[razo7]

/lgtm

[mshitrit]

/unhold