Add e2e tests for OutOfServiceTaint remediation

[k-keiichi-rh]

This PR is adding a new e2e tests for OutOfServiceTaint remediation strategy based on kubernetes/enhancements#1116.
And openshift/release#47048 depends on this pr.

[openshift-ci]

Hi @k-keiichi-rh. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mshitrit]

/test 4.12-openshift-e2e

[k-keiichi-rh]

@mshitrit Thank you for running the e2e tests in OCP4.12. The out-of-service taint is not available in OCP4.12. So the e2e test failed.
As you mentioned before, we can skip the e2e test with adding an env param like this in the OCP versions that this feature isn't supported on.

Now we have another way to do same thing using the validation way(IsOutOfServiceTaintSupported) you implemented.

I think the latter way is preferred. What do you think about it?

[mshitrit]

I think I'm leaning into env variable, but I don't have a strong preference so feel free to choose whichever implementation you prefer.

This is what I had in mind:

• in the test code env variable give more flexibility (e.g we can also turn off this test for a specific supported version if we decide so)
• implementation seems simpler
• Once a CI version that doesn't support the taint roll out, there is only an 'if' block in the code to remove instead of the version mechanism.

[k-keiichi-rh]

Thank you for the suggestion. I will take the env variable way.
The flexibility and simplicity is the most important thing as you mentioned..

[mshitrit]

/test 4.14-openshift-e2e

[openshift-ci]

@k-keiichi-rh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test 4.14-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mshitrit]

/ok-to-test

[mshitrit]

/retest

[mshitrit]

Hi @k-keiichi-rh , as expected 4.12 e2e fails because ci doesn't add the SKIP_OOST_REMEDIATION_VERIFICATION variable.
please create a PR to openshift/release and update the variable here , once tests are clear, I think we could merge.

[slintes]

openshift/release#47048

[slintes]

/lgtm
/retest

[mshitrit]

/approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: k-keiichi-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment