Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve condition name #173

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Jan 4, 2024

ECOPROJECT-1815
Improve naming for condition.

Signed-off-by: Michael Shitrit <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 4, 2024
@mshitrit
Copy link
Member Author

mshitrit commented Jan 4, 2024

/test 4.13-openshift-e2e

@slintes slintes marked this pull request as ready for review January 5, 2024 15:21
@openshift-ci openshift-ci bot requested review from razo7 and slintes January 5, 2024 15:21
@slintes
Copy link
Member

slintes commented Jan 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 5, 2024
@mshitrit mshitrit changed the title [WIP] improve condition name improve condition name Jan 7, 2024
@mshitrit
Copy link
Member Author

mshitrit commented Jan 7, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit fd6af23 into medik8s:main Jan 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants