Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pod IP for peer communication #220

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Use Pod IP for peer communication #220

merged 5 commits into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. Some fixes and e2e test improvements: 

    - re-enable and fix api check log tests in e2e test
  - use service IP for killing API connection
  - kill API connection on SNR DS pod
  - add peer check server logs and use them for test which can't
    get logs from unhealthy node's SNR agent pod
  - wait for pod deletion only, not restart (restart is caused by
    reboot, not SNR)
- refactor / cleanup e2e tests
- fix owner check / node name / machine name in peer check server
  and agent reconciler
- update sort-imports, which ignores generated files now
    @clobrano @slintes
    clobrano authored and slintes committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6f52c77 View commit details
    Browse the repository at this point in the history

  2. Use Pod IP for peer communication 

    Signed-off-by: Carlo Lobrano <[email protected]>
    @clobrano
    clobrano committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3eeeaeb View commit details
    Browse the repository at this point in the history

  3. Update terminology to reflect Pod IP usage in place of Node IP 

    Signed-off-by: Carlo Lobrano <[email protected]>
    @clobrano
    clobrano committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    54086ff View commit details
    Browse the repository at this point in the history

  4. Use core/v1 PodIP type in place than string 

    Signed-off-by: Carlo Lobrano <[email protected]>
    @clobrano
    clobrano committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    99a70db View commit details
    Browse the repository at this point in the history

  5. Return error if cannot update peers address 

    At startup (but it might happen in other moments too), some peers' Pod
IP can still be empty, which means that until the next peers update we
cannot check the connection with the other peers.

Return an error in case a peer's Pod IP is empty.

Signed-off-by: Carlo Lobrano <[email protected]>
    @clobrano
    clobrano committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cda2f3f View commit details
    Browse the repository at this point in the history