Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes and e2e test improvements #226

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Some fixes and e2e test improvements #226

merged 2 commits into from
Jul 9, 2024

Conversation

slintes
Copy link
Member

@slintes slintes commented Jul 3, 2024 •
edited
Loading

  • re-enable and fix api check log tests in e2e test
      - use service IP for killing API connection
      - kill API connection on SNR DS pod
      - add peer check server logs and use them for test which can't get logs from unhealthy node's SNR agent pod
      - wait for pod deletion only, not restart (restart is caused by reboot, not SNR)
  • refactor / cleanup e2e tests
  • fix owner / node name / machine name check in peer check server and agent reconciler
  • update sort-imports, which ignores generated files now

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Jul 3, 2024
@slintes
Copy link
Member Author

slintes commented Jul 3, 2024

/test 4.15-openshift-e2e

3 similar comments
@slintes
Copy link
Member Author

slintes commented Jul 3, 2024

/test 4.15-openshift-e2e

@slintes
Copy link
Member Author

slintes commented Jul 3, 2024

/test 4.15-openshift-e2e

@slintes
Copy link
Member Author

slintes commented Jul 4, 2024

/test 4.15-openshift-e2e

@slintes
Copy link
Member Author

slintes commented Jul 8, 2024

/test 4.15-openshift-e2e

@slintes slintes mentioned this pull request Jul 8, 2024
Closed
@slintes
Copy link
Member Author

slintes commented Jul 8, 2024

/test 4.15-openshift-e2e

1 similar comment
@slintes
Copy link
Member Author

slintes commented Jul 9, 2024

/test 4.15-openshift-e2e

@clobrano @slintes
Some fixes and e2e test improvements:
6f52c77 
- re-enable and fix api check log tests in e2e test
  - use service IP for killing API connection
  - kill API connection on SNR DS pod
  - add peer check server logs and use them for test which can't
    get logs from unhealthy node's SNR agent pod
  - wait for pod deletion only, not restart (restart is caused by
    reboot, not SNR)
- refactor / cleanup e2e tests
- fix owner check / node name / machine name in peer check server
  and agent reconciler
- update sort-imports, which ignores generated files now
@slintes
Copy link
Member Author

slintes commented Jul 9, 2024

/test 4.15-openshift-e2e

@slintes slintes changed the title WIP Test e2e - take 2 Some fixes and e2e test improvements Jul 9, 2024
@slintes slintes mentioned this pull request Jul 9, 2024
Closed
clobrano
clobrano requested changes Jul 9, 2024
View reviewed changes
pkg/peerhealth/server.go Outdated Show resolved Hide resolved
pkg/peerhealth/server.go Show resolved Hide resolved
@slintes
small adjustments
444a703 
- make some functions private
- improve logs message

Signed-off-by: Marc Sluiter <[email protected]>
@slintes slintes marked this pull request as ready for review July 9, 2024 15:46
@openshift-ci openshift-ci bot requested review from mshitrit and razo7 July 9, 2024 15:46
clobrano
clobrano approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
keeping the hold for the other threads
/hold

@openshift-ci openshift-ci bot added the lgtm label Jul 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member

mshitrit commented Jul 9, 2024

/unhold

@slintes slintes mentioned this pull request Jul 9, 2024
Merged
@slintes
Copy link
Member Author

slintes commented Jul 9, 2024

strange error for ds pod creation in 4.13:

"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory"

since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220

/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.9

@openshift-cherrypick-robot
Copy link

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

strange error for ds pod creation in 4.13:

"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory"

since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220

/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.13-openshift-e2e

In response to this:

strange error for ds pod creation in 4.13:

"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory"

since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220

/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4c8286e into medik8s:main Jul 9, 2024
26 checks passed
@openshift-cherrypick-robot
Copy link

@slintes: new pull request created: #233

In response to this:

strange error for ds pod creation in 4.13:

"container create failed: time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T17:26:51Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory"

since 4.12 and 4.14 are green I will override. Let's keep an eye on it in #220

/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano clobrano approved these changes

@mshitrit mshitrit Awaiting requested review from mshitrit

@razo7 razo7 Awaiting requested review from razo7

Assignees

@clobrano clobrano

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slintes @mshitrit @openshift-cherrypick-robot @clobrano