Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message #229

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

slintes
Copy link
Member

@slintes slintes commented Jul 5, 2024

Why we need this PR

Slightly wrong log message:

2024-07-05T06:32:29.280007573Z INFO rebootDurationCalculator No SafeTimeToAssumeNodeRebootedSeconds specified, using calculated minimum safe reboot time {"calculated minimum time in seconds": "2m0s"}

Should be 120 instead of 2m0s

Changes made

Take Seconds() from duration in log

Fixes ECOPROJECT-2025

Signed-off-by: Marc Sluiter <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Jul 5, 2024
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes slintes marked this pull request as ready for review July 5, 2024 07:52
@openshift-ci openshift-ci bot requested review from mshitrit and razo7 July 5, 2024 07:52
@slintes
Copy link
Member Author

slintes commented Jul 5, 2024

/cherry-pick release-0.9

@openshift-cherrypick-robot

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9238c04 into medik8s:main Jul 5, 2024
26 checks passed
@openshift-cherrypick-robot

@slintes: new pull request created: #230

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants