Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#210 - Add Basic Auth to direct broker #211

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

michael-82
Copy link
Collaborator

  • add username and password env vars
  • add auth interceptors to both fhir (cql) and spring (flare) clients
  • (unrelated...add volume to docker compose file)

@michael-82 michael-82 self-assigned this Oct 4, 2023
@michael-82 michael-82 linked an issue Oct 4, 2023 that may be closed by this pull request
@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch from fc6d163 to f163295 Compare November 2, 2023 10:35
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (13a656b) 74.12% compared to head (fd7562e) 74.48%.

Files Patch % Lines
...ackend/query/broker/direct/DirectSpringConfig.java 89.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #211      +/-   ##
=============================================
+ Coverage      74.12%   74.48%   +0.35%     
- Complexity       523      530       +7     
=============================================
  Files            124      124              
  Lines           2211     2226      +15     
  Branches         105      106       +1     
=============================================
+ Hits            1639     1658      +19     
+ Misses           512      506       -6     
- Partials          60       62       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch from f163295 to 4c1127d Compare November 3, 2023 08:41
@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch from 4c1127d to 3510187 Compare November 10, 2023 10:37
@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch 2 times, most recently from 8e1a84b to 57b9c5c Compare November 22, 2023 14:09
@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch from 3474f8b to c379ebf Compare January 8, 2024 15:32
@michael-82 michael-82 marked this pull request as ready for review January 8, 2024 15:33
@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch 4 times, most recently from acdebd9 to a2f71a9 Compare January 10, 2024 14:45
- add username and password env vars
- add auth interceptors to both fhir (cql) and spring (flare) clients
- (unrelated...add volume to docker compose file)
@michael-82 michael-82 force-pushed the feature/210-add-basic-auth-to-direct-broker branch from a2f71a9 to fd7562e Compare January 10, 2024 14:49
Copy link
Collaborator

@EmteZogaf EmteZogaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-82 michael-82 removed the request for review from juliangruendner January 11, 2024 07:47
@michael-82 michael-82 merged commit 8f70bb0 into develop Jan 11, 2024
8 checks passed
@michael-82 michael-82 deleted the feature/210-add-basic-auth-to-direct-broker branch January 11, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Basic Auth to direct broker
2 participants