#401 - Update sq2cql and validate time restrictions #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-82
commented
Nov 22, 2024
michael-82
commented
- update sq2cql to 0.6.0-SNAPSHOT
- check if timerestrictions are correct (before date is after afterdate)
- added new validation issue code to be returned to the gui. please check if this is ok this way and let me know if it should be something else (@juliangruendner @Shayan1375 @thkoehler11 )
|
Currently the build fails because the snapshot version of sq2cql is not in the maven repo. Will re-open when it is released |
- update sq2cql to 0.6.0-SNAPSHOT - check if timerestrictions are correct (before date is after afterdate)
- update sq2cql to 0.6.0
michael-82
force-pushed
the
feature/401-update-sq2cql-and-validate-time-restrictions
branch
from
1624479 to
eebdcfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #402 +/- ##
=============================================
+ Coverage 78.43% 78.53% +0.09%
- Complexity 552 556 +4
=============================================
Files 138 138
Lines 2407 2418 +11
Branches 147 149 +2
=============================================
+ Hits 1888 1899 +11
Misses 461 461
Partials 58 58 ☔ View full report in Codecov by Sentry. |
michael-82
deleted the
feature/401-update-sq2cql-and-validate-time-restrictions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.