Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#334 - Re-enable CodeableConceptServiceIT #417

Merged
merged 5 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/integration-test/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ services:
POSTGRES_DB: "dataportal"

dataportal-elastic:
image: docker.elastic.co/elasticsearch/elasticsearch:8.16.0
image: docker.elastic.co/elasticsearch/elasticsearch:8.16.1
container_name: dataportal-elastic
ports:
- '9200:9200'
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ services:
source: dataportal-postgres-data
target: /var/lib/postgresql/data
dataportal-elastic:
image: docker.elastic.co/elasticsearch/elasticsearch:8.16.0
image: docker.elastic.co/elasticsearch/elasticsearch:8.16.1
container_name: dataportal-elastic
ports:
- '9200:9200'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertNotNull;

@Disabled("There seems to be a concurrency issue with TerminologyServiceIT. Disable this for now until it is fixed.")
@Tag("terminology")
@Tag("elasticsearch")
@Import({CodeableConceptService.class})
Expand All @@ -46,7 +45,7 @@ public class CodeableConceptServiceIT {

@Container
@ServiceConnection
public static ElasticsearchContainer ELASTICSEARCH_CONTAINER = new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:8.16.0")
public static ElasticsearchContainer ELASTICSEARCH_CONTAINER = new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:8.16.1")
.withEnv("discovery.type", "single-node")
.withEnv("xpack.security.enabled", "false")
.withReuse(false)
Expand All @@ -56,7 +55,7 @@ public class CodeableConceptServiceIT {
.waitingFor(Wait.forHttp("/health").forStatusCodeMatching(c -> c >= 200 && c <= 500));

@BeforeAll
static void setUp() {
static void setUp() throws InterruptedException {
ELASTICSEARCH_CONTAINER.start();
WebClient webClient = WebClient.builder().baseUrl("http://" + ELASTICSEARCH_CONTAINER.getHttpHostAddress()).build();
webClient.put()
Expand All @@ -72,6 +71,9 @@ static void setUp() {
.retrieve()
.toBodilessEntity()
.block();

// When running in github actions without a slight delay, the data might not be complete in the elastic search container (although a blocking call is used)
Thread.sleep(1000);
}

@AfterAll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class TerminologyEsServiceIT {

@Container
@ServiceConnection
public static ElasticsearchContainer ELASTICSEARCH_CONTAINER = new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:8.16.0")
public static ElasticsearchContainer ELASTICSEARCH_CONTAINER = new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:8.16.1")
.withEnv("discovery.type", "single-node")
.withEnv("xpack.security.enabled", "false")
.withReuse(false)
Expand Down
Loading