Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for binary streaming #35

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add support for binary streaming #35

wants to merge 3 commits into from

Conversation

wetret
Copy link
Member

@wetret wetret commented Dec 18, 2024

resolves #34

@wetret wetret added this to the v1.1.0.0 milestone Dec 18, 2024
@wetret wetret requested a review from hhund December 18, 2024 14:26
@wetret wetret self-assigned this Dec 18, 2024
@wetret wetret linked an issue Jan 2, 2025 that may be closed by this pull request
Read Binary Content as Stream instead of a Binary Ressource #34
Open
@wetret wetret mentioned this pull request Jan 3, 2025
Open
hhund
hhund requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@hhund hhund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still Binary resource being serialized between BPMN tasks. Is this enough of an improvement to handle larger Binary resource?

@wetret
Copy link
Member Author

wetret commented Mar 4, 2025 •
edited
Loading

There are still Binary resource being serialized between BPMN tasks. Is this enough of an improvement to handle larger Binary resource?

I became aware of that as well, but already startet implementing for the Multiple Attachments support. Therefore the comments you wrote should be fixed in PR #37

@wetret wetret requested a review from hhund March 4, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhund hhund Awaiting requested review from hhund

Assignees

@wetret wetret

Labels
None yet
Projects
None yet
Milestone
v1.1.0.0
Development

Successfully merging this pull request may close these issues.

Read Binary Content as Stream instead of a Binary Ressource
2 participants
@wetret @hhund