Correcting Path of the checkpoint saved changing ":" to "_" #21 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, thanks. I believe a greater enhancement would be to use established standards for timestamp representation in the filename, instead of rolling our own. See this thread for relevant discussion points about different formats. |
|
For the basic form of ISO 8601, it's a one-liner: >>> datetime.datetime.utcnow().strftime("%Y%m%dT%H%M%SZ")
'20240219T091453Z' |
Closes medkit-lib#21 Co-Authored-By: Ghislain Vaillant <[email protected]>
ghisvail
force-pushed
the
21-problem-saving-model-training
branch
from
c5eca23 to
ec956ec
Compare
|
I modified your PR to switch the offending suffix to an ISO 8601 compliant timestamp. Once this PR is merged, I'll follow it up with a release. Feel free to try it and report other Windows related problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT by @ghisvail
Closes #21