Fix incorrect parsing of StringDataEncoding XML elements and resultin…

…g parsing bugs for parsing strings themselves Return bytes objects for raw strings and str objects for derived values.
medley56 · Oct 2, 2024 · fa3c575 · fa3c575
1 parent 27ac73c
commit fa3c575
Show file tree

Hide file tree

Showing 5 changed files with 324 additions and 187 deletions.
diff --git a/docs/source/changelog.md b/docs/source/changelog.md
@@ -23,6 +23,8 @@ Release notes for the `space_packet_parser` library
 - BREAKING: Removed `word_size` kwarg from packet generator method. 
   We expect all binary data to be integer number of bytes.
 - BREAKING: Changed `packet_generator` kwarg `skip_header_bits` to `skip_header_bytes`.
+- Fixed incorrect parsing of StringDataEncoding elements. Raw string values are now returned as byte buffers. 
+  Derived string values contain python string objects.
 - The ``CCSDSPacket`` class is now a dictionary subclass, enabling direct lookup of items from the Packet itself.
 - A ``RawPacketData`` class has been added that is a subclass of bytes. It keeps track of the current
   parsing location and enables reading of bit lengths as integers or raw bytes.

diff --git a/pyproject.toml b/pyproject.toml
@@ -50,7 +50,6 @@ myst-parser = "*"
 sphinx-autoapi = "*"
 sphinx-rtd-theme = "*"
 coverage = "*"
-numpy = "*"
 
 [tool.poetry.group.examples]
 optional = true