DRAFT: feat: [DIOS-6664] Add stream view id to relevant log messages #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcostdolby
commented
Aug 28, 2024
bcostdolby
commented
Aug 28, 2024
murillo128
reviewed
Sep 3, 2024
| @@ -275,6 +278,8 @@ class Transponder extends Emitter | |||
| /** | |||
| * Select encoding and temporal and spatial layers based on the desired bitrate. This operation will unmute the transponder if it was muted and it is possible to select an encoding and layer based on the target bitrate and options. | |||
| * | |||
| * @deprecated since version 1.149. Will be deleted in version 2.0. Please use setTargetBitrateAsync instead | |||
There was a problem hiding this comment.
iirc there was a problem with the @deprecated and ts anotations, @mildsunrise am I wrong?
| @@ -417,6 +433,8 @@ class Transponder extends Emitter | |||
| layers : layers | |||
| }); | |||
| } else { | |||
| this.logger?.warn(`-Transponder::setTargetBitrate() Unable to locate layer suitable for target bitrate ${target} and strict mode, so muting`); | |||
There was a problem hiding this comment.
better create a child logger with transponder on constructor id and just have the method name here.
Suggested change
| this.logger?.warn(`-Transponder::setTargetBitrate() Unable to locate layer suitable for target bitrate ${target} and strict mode, so muting`); | |
| this.logger?.warn(`-setTargetBitrate() Unable to locate layer suitable for target bitrate ${target} and strict mode, so muting`); |
bcostdolby
force-pushed
the
dev/bcost/DIOS-6664-logid
branch
from
b95e6e2
to
9cfba12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs the new logger repo logger-node
Needs the PR in media-server-src: medooze/media-server#325