-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/add additionl data to product categories hook #11226
Fix/add additionl data to product categories hook #11226
Conversation
🦋 Changeset detectedLatest commit: d55d455 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@bouazzaayyoub is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hello, |
hello, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@bouazzaayyoub you're missing whitelisting the additional_data param in the http validators - If you can write a simple test for this, would be great! |
thank you for your reply |
…l_data_to_product_categories_hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change @bouazzaayyoub, i've added a couple of comments on the new change.
Legend, thanks for the contribution @bouazzaayyoub! |
Add an
additional_data
property to thecategoriesCreated
hook, enabling users to extend the Product Category model.