Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows, types): calculated shipping in RMA flows #11533

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

feat(core-flows, types): calculated shipping in RMA flows #11533

wants to merge 26 commits into from
+2,018 −235

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Feb 19, 2025 •
edited
Loading

What

  • support calculated shipping options in the return / exchange / claim flow

How

  • introduced 2 util workflows (reused across all 3 RMA flows)
    • fetchShippingOptionForOrderWorkflow
      • retrieves a shipping option with pricing
      • used when adding a shipping method to an RMA flow
    • maybeRefreshShippingMethodsWorkflow
      • used to update a shipping method and corresponding action if the shipping option is calcualted
  • added refresh(Return|Claim|Exchange)ShippingWorkflow
    • retrieves relevant data for the flow and calls maybeRefreshShippingMethodsWorkflow
    • called in all places where items in the RMA flow are updated
calculated.rma.mp4

CLOSES CMRC-806

@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 2:23pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 26, 2025 2:23pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:23pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:23pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:23pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:23pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:23pm
user-guide ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:23pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f56ff9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic changed the title wip(core-flows, types): calculated shipping in Return flow feat(core-flows, types): calculated shipping in Return flow Feb 21, 2025
@fPolic fPolic marked this pull request as ready for review February 21, 2025 12:18
@fPolic fPolic requested a review from a team as a code owner February 21, 2025 12:18
olivermrbl
olivermrbl reviewed Feb 23, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I get you to describe how we have achieved this in the PR description?

packages/core/types/src/fulfillment/mutations/shipping-option.ts Outdated
/**
* The return details - if present, the return shipping needs to be calculated.
*/
orderReturn?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: Let's clean up this entire type while we're at it. The mixing of the casing is triggering 😄

I think this needs to be camel_cased. Please deprecate (and add a todo) the ones that are changed, so we avoid breaking the type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the type. The type is only extended with new properties so there shouldn't be a breaking change.

@fPolic fPolic marked this pull request as draft February 24, 2025 11:06
@fPolic fPolic changed the title feat(core-flows, types): calculated shipping in Return flow feat(core-flows, types): calculated shipping in RMA flows Feb 24, 2025
@fPolic fPolic marked this pull request as ready for review February 26, 2025 12:08
@fPolic fPolic requested review from carlos-r-l-rodrigues and removed request for christiananese February 26, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl left review comments

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl