Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error #3507

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

itsmeabhishek03
Copy link
Contributor

Fixes #3506

This PR resolves TypeScript compilation errors caused by missing explicit types in the GetScreenCallback type definition in janus.d.ts.

Issue Details:
Problem: The GetScreenCallback type was defined as:

type GetScreenCallback = (error?, sourceId?) => void;
This caused TypeScript errors (TS7006) when compiling in strict mode, as the parameters error and sourceId implicitly had the any type.

Solution: The parameters have been updated with explicit types to ensure compatibility with strict TypeScript settings:
type GetScreenCallback = (error:string, sourceId:string) => void

@januscla
Copy link

Thanks for your contribution, @itsmeabhishek03! Please make sure you sign our CLA, as it's a required step before we can merge this.

@lminiero
Copy link
Member

Thanks for spotting this and for the fix, @itsmeabhishek03, merging!

@lminiero lminiero merged commit 0f64915 into meetecho:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.3.0]Parameter 'error' and 'sourceId' implicitly has an 'any' type.
3 participants