Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peternewnham
Copy link

This fix updates the selectors used to determine whether there is a notification for in Hangouts Chat.

Additionally fixes an issue with indirect message count not being incremented correctly

Issue was originally logged at https://github.com/meetfranz/franz/issues/1456

@helms-charity
Copy link

Hi, I want to try out your fix, but my question is what is the difference between Hangouts Chat and this Hangouts recipe? https://github.com/meetfranz/recipe-hangouts
THanks...

@peternewnham
Copy link
Author

This recipe is for Hangouts Chat (chat.google.com) which is a different product to Classic Hangouts (hangouts.google.com) which the recipe you linked to is for

@ilopmar
Copy link

ilopmar commented Aug 5, 2019

I was about to open an issue and I've found this PR 👍
@adlk do you plan to merge this? or is it some kind of snapshot version that includes it so we can test it? Thanks!

@jerivas
Copy link

jerivas commented Oct 9, 2019

Please merge! I've missed so many Chat notifications because of the missing dot

@ilopmar
Copy link

ilopmar commented Nov 3, 2019

Is there anything we can do to help with the test so this can be merged? Thanks :)

@Llorx
Copy link

Llorx commented Jan 28, 2020

Sorry for being pushy, but we are already in 2020 and Hangouts Chat is still buggy. Merge?

@ilopmar
Copy link

ilopmar commented Jan 28, 2020

I discovered how to add the recipe locally so I cloned the repo, merged the pending PRs and publish it here: https://github.com/ilopmar/recipe-hangoutschat with the instructions on how to use it. I've been using it for a couple of weeks without any problem and I get notifications working :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants