-
Notifications
You must be signed in to change notification settings - Fork 83
Added Python Package #9
base: master
Are you sure you want to change the base?
Added Python Package #9
Conversation
f0d21fd
to
2c443ab
Compare
|
||
__name__ = "Instagram Scraper" | ||
__author__ = "Meet Mangukiya <[email protected]>" | ||
__version__ = '1.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a stable API yet, 0.1.0
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import scrape_instagram_tag
, and scrape_instagram
here... from instagram_scraper.instagram_scraper import ...
is too long.
), | ||
entry_points={ | ||
'console_scripts': [ | ||
'scrape-insta = instagram_scraper.instagram_scraper:run', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer scrape-instagram
@@ -0,0 +1,5 @@ | |||
from .instagram_scraper import main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need main here?
@vaibhavsingh97 did a small review, thanks for the PR! |
@meetmangukiya Sorry for keep you waiting this much longer. I will update this PR asap 👍 |
Do-not-merge: Need Testing and also have to modify where all file downloads