-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use conditional sound libs for compiling on newer linux distros #781
base: main
Are you sure you want to change the base?
build: use conditional sound libs for compiling on newer linux distros #781
Conversation
@tornadia |
@tornadia |
Will this fix the pipeline issues? No idea! But I sure hope so :D
Hi Mehah! I appreciate your thorough reviews to push this effort further and get it merged. I am planning to resolve the issue by removing the quotation marks and maybe separating the setters into different lines further if that doesn't work. In my local environment it is working fine. Can you suggest an approach to resolve this? |
This PR is stale because it has been open 45 days with no activity. |
This PR is stale because it has been open 45 days with no activity. |
Description
Fixes compiling on Ubuntu with disabled sound
Behavior
Actual
Doesnt compile if sound is used
Expected
Makes it possible to disable sound again
Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist