Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: update vcpkg baseline #899

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

improve: update vcpkg baseline #899

wants to merge 5 commits into from

Conversation

mehah
Copy link
Owner

@mehah mehah commented Oct 2, 2024

in vcpkg folder:
git pull
vcpkg upgrade --no-dry-run

@OTArchive
Copy link
Contributor

OTArchive commented Oct 4, 2024

Abseil is no longer included with protobuf, it's now necessary to include it. You can see how I've done it for the browser version, but I'm not experienced. Please let me know if there's a better way.

@mehah
Copy link
Owner Author

mehah commented Oct 4, 2024

@OTArchive

Abseil is no longer included with protobuf, it's now necessary to include it. You can see how I've done it for the browser version, but I'm not experienced. Please let me know if there's a better way.

It says to put it in vcpkg.json?

Strange that protobuf was supposed to have put Abseil as a dependency, if that is really the problem.

@OTArchive
Copy link
Contributor

@OTArchive

Abseil is no longer included with protobuf, it's now necessary to include it. You can see how I've done it for the browser version, but I'm not experienced. Please let me know if there's a better way.

It says to put it in vcpkg.json?

Strange that protobuf was supposed to have put Abseil as a dependency, if that is really the problem.

In my case I had to explicitly include it using CMakeLists so it could find the libs to link to. I did not use vcpkg.json though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants