Merge pull request #58 from mehrancodes/fix-text-to-array-parse-srt

#57 Enhanced TextToArray action

app/Actions/TextToArray.php

@@ -28,7 +28,16 @@ public function handle(?string $content): ?array
 
         $separator = Str::contains($content, ';') ? ';' : "\n";
 
-        parse_str(str_replace($separator, '&', $content), $output);
+        $output = [];
+        foreach (explode($separator, $content) as $variable) {
+            $var = explode('=', $variable, 2);
+
+            if (empty($var[0]) || empty($var[1])) {
+                return [];
+            }
+
+            $output[$var[0]] = $var[1];
+        }
 
         return $output;
     }

tests/Feature/Actions/TextToArrayTest.php

@@ -0,0 +1,38 @@
+<?php
+
+use App\Actions\TextToArray;
+
+it('it converts key/value strings to array by semicolon and new-line', function ($actual, $expected) {
+    expect(
+        TextToArray::run(
+            $actual['content'],
+        )
+    )
+        ->toBe($expected);
+})
+    ->with([
+        [
+            'actual' => [
+                'content' => "GOOGLE_API=MY_API_KEY;APP_KEY=ba=)(*&^%$#@!se64:psYUiUHUTds+8TLxgsUqAw=",
+            ],
+            'expected' => [
+                'GOOGLE_API' => 'MY_API_KEY',
+                'APP_KEY' => 'ba=)(*&^%$#@!se64:psYUiUHUTds+8TLxgsUqAw='
+            ],
+        ],
+        [
+            'actual' => [
+                'content' => "GOOGLE_API=MY_API_KEY\nGITHUB_API=MY_SECOND_KEY",
+            ],
+            'expected' => [
+                'GOOGLE_API' => 'MY_API_KEY',
+                'GITHUB_API' => 'MY_SECOND_KEY'
+            ],
+        ],
+        [
+            'actual' => [
+                'content' => "GOOGLE_API=MY_API_KEY\nINVALID_COMMENT INVALID_VALUE\nGITHUB_API=MY_SECOND_KEY",
+            ],
+            'expected' => [],
+        ],
+    ]);