Make documentation compatible with node 16 #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
commented
May 25, 2022
maryamsulemani97
approved these changes
May 25, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1323
This PR becomes important as node 14 entered maintenance mode and will soon be EOL. Node 16 is now the current version and soon enough node 18 will takes its place.
The documentation was not compatible with node 16 because it used
vuepress-plugin-element-tabsthat itself usednode-sassthat is deprecated.I created a fork of that same plugin
@bidoubiwa/vuepress-plugin-elements-tabsthat upgradednode-sasstosass. Which makes it compatible with node 16.This PR also upgrades all
actions/setup-nodefrom v2 to v3 as v3 uses by default node v16.A good consideration would also be to upgrade netlify node version to 16 if it is possible.