-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update known_limitations.mdx #2530
Conversation
Implement New known limitation about facet search.
Hi @RyanGoudie01! Thanks for the PR, it's really appreciated. I just returned from my holidays, but wanted to let you know I'll be looking into it sometime during this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RyanGoudie01!
I made a couple of suggestions to your PR so it better addresses the issues and confusion reported by users.
I got the impression from your past messages you might be interested in documentation. If that's the case, here's a couple of general notes you may find interesting:
- when referring to things that exist in the code, like variable or functions, format them correctly to indicate that. In markdown, which we use in this repository, that would be backticks (
`
). For example:maxValuesPerFacet
; - we avoid using "currently" as much as possible—the documentation's task is to help people use our software now, so in most cases "currently" is implied and unnecessary;
Thanks again!
Update commit with suggested changes Co-authored-by: gui machiavelli <[email protected]>
Update with suggested change Co-authored-by: gui machiavelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to review my comments, @RyanGoudie01!
PR approved, merging
Implement New known limitation about facet search.
Pull Request
Related issue
Fixes #2529 >
What does this PR do?
PR checklist
Please check if your PR fulfils the following requirements:
Thank you so much for contributing to Meilisearch!