Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics events (CTR, conversion) instructions #2677

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

brunoocasali
Copy link
Member

Pull Request

Related issue

Fixes meilisearch/meilisearch#4302

What does this PR do?

  • Just fixing some code sample mistakes in the docs about the edge event handling!

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:brunoocasali-patch-1

Credentials to access the page are in the company's password manager as "Docs deploy preview".

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Bruno!

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @brunoocasali! 🙇

LGTM, merging

@guimachiavelli guimachiavelli merged commit 02fbce7 into main Jan 8, 2024
2 checks passed
@guimachiavelli guimachiavelli deleted the brunoocasali-patch-1 branch January 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meilisearch Cloud: Status code 405 when capturing analytics click event
4 participants