Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud getting started video #2766

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add Cloud getting started video #2766

merged 1 commit into from
Mar 26, 2024

Conversation

CaroFG
Copy link
Contributor

@CaroFG CaroFG commented Mar 20, 2024

Pull Request

Adds Cloud getting started video

Thank you so much for contributing to Meilisearch!

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:add-cloud-video

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@CaroFG CaroFG marked this pull request as draft March 20, 2024 15:42
@CaroFG CaroFG marked this pull request as ready for review March 21, 2024 14:14
@Strift
Copy link
Contributor

Strift commented Mar 25, 2024

LGTM

But the video starts displaying other suggested videos from our channel around 1:05. I think that's too early, especially since it's hiding most of the video content. Can we configure that?

Other than that, it works as expected.

@CaroFG
Copy link
Contributor Author

CaroFG commented Mar 25, 2024

I removed video recommendations

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guimachiavelli guimachiavelli merged commit e23ad8e into main Mar 26, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the add-cloud-video branch March 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants