Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling large documents guide #2767

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Handling large documents guide #2767

merged 9 commits into from
Apr 17, 2024

Conversation

guimachiavelli
Copy link
Member

Closes #310

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:large-documents-guide

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review March 25, 2024 18:05
Co-authored-by: Clément Renault <[email protected]>
@curquiza
Copy link
Member

curquiza commented Mar 27, 2024

It's happening!! 🎉 Well done gui!!

@guimachiavelli
Copy link
Member Author

Thanks for the feedback, @Kero. I corrected the numbers for what Meilisearch considers a large document according to your recommendation (not really sure where I got the initial numbers, but I did think they were much larger than what I would have expected).

Kerollmops
Kerollmops previously approved these changes Mar 28, 2024
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect! Thank you Gui 😃

Kerollmops
Kerollmops previously approved these changes Mar 29, 2024
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@guimachiavelli guimachiavelli merged commit 08e3324 into main Apr 17, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the large-documents-guide branch April 17, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advise about big documents that should be split
4 participants