Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link checker build #2802

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Link checker build #2802

merged 4 commits into from
Apr 17, 2024

Conversation

zeguillen
Copy link
Contributor

Pull Request

What does this PR do?

  • Provides the compiled changes for the link checker

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:joseg/link-checker-build

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli requested a review from curquiza April 17, 2024 09:39
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeguillen I cannot see the changes you made on the first file, can you show them?

Capture d’écran 2024-04-17 à 12 24 42

Copy link
Contributor Author

@zeguillen zeguillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @curquiza, sure, the changes to the source were made on this previous PR, here we are only providing the compiled source.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zeguillen
I approve but I'm not sure I can challenge the code anyway

Let's see if it works 🤞

@guimachiavelli guimachiavelli merged commit 8979125 into main Apr 17, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the joseg/link-checker-build branch April 17, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants