-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump trim, remark-parse and remark-rehype in /.github/actions/validate-docs-links #2803
Conversation
Removes [trim](https://github.com/Trott/trim). It's no longer used after updating ancestor dependencies [trim](https://github.com/Trott/trim), [remark-parse](https://github.com/remarkjs/remark) and [remark-rehype](https://github.com/remarkjs/remark-rehype). These dependencies need to be updated together. Removes `trim` Updates `remark-parse` from 7.0.1 to 11.0.0 - [Release notes](https://github.com/remarkjs/remark/releases) - [Changelog](https://github.com/remarkjs/remark/blob/main/changelog.md) - [Commits](https://github.com/remarkjs/remark/compare/[email protected]@11.0.0) Updates `remark-rehype` from 5.0.0 to 11.1.0 - [Release notes](https://github.com/remarkjs/remark-rehype/releases) - [Commits](remarkjs/remark-rehype@5.0.0...11.1.0) --- updated-dependencies: - dependency-name: trim dependency-type: indirect - dependency-name: remark-parse dependency-type: direct:production - dependency-name: remark-rehype dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
@zeguillen, I believe you're in a better position to assess whether these updates can have any impact on our pipeline. |
"remark-parse": "7.0.1", | ||
"remark-rehype": "5.0.0", | ||
"remark-parse": "11.0.0", | ||
"remark-rehype": "11.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a local test with both these new versions and they break the pipeline, they have documented breaking changes (remark-rehype v6), so I would suggest avoiding an update at this time @guimachiavelli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea, yeah. I'm glad I asked your review before blindly merging this one 😅
According to the developer's guidance, updating |
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Hello @zeguillen This dependabot update is a security update. I'm not comfortable knowing we are not able to update the dependencies, even if it's on a tool, not on the website itself. The repository is open-source, so the tool is publicly available. Do you know why we use such an old |
Hey @curquiza, I've checked with the team and it seems these two libraries are tied to the Please let me know! |
Removes trim. It's no longer used after updating ancestor dependencies trim, remark-parse and remark-rehype. These dependencies need to be updated together.
Removes
trim
Updates
remark-parse
from 7.0.1 to 11.0.0Release notes
Sourced from remark-parse's releases.
... (truncated)
Commits
de740c7
remark-parse: 11.0.01a769dd
Fix TS generating broken definitions98a2560
Change to require Node.js 16350645a
Fix license6a43da8
Refactor docsc348aec
Refactor some metadataa3e6d54
Change to useexports
bd8c922
Add typed settings63e6ef9
Refactor code-styled5a134d
Remove tests for things in micromark, mdast utilitiesUpdates
remark-rehype
from 5.0.0 to 11.1.0Release notes
Sourced from remark-rehype's releases.
... (truncated)
Commits
6407b61
11.1.00174dfc
Addfile
to options passed tomdast-util-to-hast
cf87ade
Update dev-dependenciesb4799b5
11.0.030091c7
Change to require Node.js 16cafeacc
Change to useexports
b990986
Add exports ofdefaultFootnoteBackContent
,defaultFootnoteBackLabel
ba50965
RemoveProcessor
type743e91b
Refactor docs4009084
Refactor code-styleDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.