Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8: Add new embedder sources #2804

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

guimachiavelli
Copy link
Member

Closes #2795, #2796

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:v1.8-rest-ollama-embedder

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli added the new release Changes related upcoming Meilisearch releases label Apr 22, 2024
@guimachiavelli guimachiavelli marked this pull request as ready for review April 22, 2024 16:44
@guimachiavelli guimachiavelli added this to the v1.8 milestone Apr 23, 2024
This was linked to issues Apr 23, 2024
@macraig
Copy link
Contributor

macraig commented Apr 23, 2024

@guimachiavelli I think we might be missing the distributionShift setting? (API link)

@guimachiavelli
Copy link
Member Author

Thanks for bringing that up, @macraig. distributionShift was bundled with other hybrid search changes and I missed it when planning v1.8 updates. I'll open a separate PR to cover that.

learn/experimental/vector_search.mdx Outdated Show resolved Hide resolved
learn/experimental/vector_search.mdx Outdated Show resolved Hide resolved
learn/experimental/vector_search.mdx Outdated Show resolved Hide resolved
learn/experimental/vector_search.mdx Show resolved Hide resolved
@guimachiavelli guimachiavelli dismissed Kerollmops’s stale review April 24, 2024 16:19

decided with product manager to define remaining parameters after launch, other comments were properly addressed

@guimachiavelli guimachiavelli merged commit 16f2601 into v1.8 Apr 24, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the v1.8-rest-ollama-embedder branch April 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new release Changes related upcoming Meilisearch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.8: Ollama embedder support v1.8: Generic REST embedder
4 participants