Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.11: Add STARTS WITH to filter expression reference #3019

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

guimachiavelli
Copy link
Member

Closes #2989

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:v1.11-starts-with

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli marked this pull request as ready for review October 8, 2024 15:22
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the operator not containing an underscore, looks good to me! Thank you gui 🙂

Co-authored-by: Clément Renault <[email protected]>
@guimachiavelli
Copy link
Member Author

🤦 I have no explanation for the underscore except that I'm dumb.

Thanks for spotting it!

@guimachiavelli guimachiavelli changed the title v1.11: Add STARTS_WITH to filter expression reference v1.11: Add STARTS WITH to filter expression reference Oct 9, 2024
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also probably modify those occurrences too 🤔

@guimachiavelli
Copy link
Member Author

Beat me to it, I was reviewing the changelog before doing a final review of this PR, thanks!

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Gui, thank you very much!

@guimachiavelli guimachiavelli merged commit 452c18d into v1.11 Oct 9, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the v1.11-starts-with branch October 9, 2024 12:09
@guimachiavelli guimachiavelli linked an issue Oct 9, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.11: Experimental: New STARTS_WITH filter operator
3 participants