Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to JWT website at the top section of the page #3034

Closed
wants to merge 8 commits into from

Conversation

postmeback
Copy link
Contributor

Fixes #2893

Textual Changes. Added link to JWT website at the top section of the page

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@postmeback
Copy link
Contributor Author

Changed as per #2893 comments. Requesting for review

@guimachiavelli
Copy link
Member

Hello again @postmeback—thanks for the continued interest in contributing to the Meilisearch documentation repository.

While this is an improvement, it still doesn't meet our quality criteria and I'm afraid I must once again refuse your PR. As I mentioned on #2928, it is important the link is integrated within the text, which more or less excludes links with "click here".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference jwt.io in tenant tokens documentation
2 participants