-
Notifications
You must be signed in to change notification settings - Fork 66
Introduce the Env::nested_read_txn from an RwTxn
#307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kerollmops
wants to merge
23
commits into
main
Choose a base branch
from
allow-nested-rtxn-from-wtxn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+210
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95d39b5 to
f7651f0
Compare
This was referenced Jan 27, 2025
Kerollmops
commented
Feb 26, 2025
9a94c8a to
1d1926b
Compare
a54defd to
05d9f22
Compare
484b166 to
95a3907
Compare
This was referenced Oct 1, 2025
9dfc1cd to
6eb0384
Compare
Kerollmops
commented
Oct 22, 2025
f70c41b to
4a88b58
Compare
1ef547f to
5f56c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at patching LMDB to be capable of initiating multiple
RoTxnfrom anRwTxnand, therefore, be able to read the content of an uncommittedRwTxnin parallel. You can find the LMDB patch in the dedicated fork. We can run many algorithms in Meilisearch to process the uncommitted changes and generate new data structures before committing the transaction.This PR is open, but we also have it on crates.io under the v0.22.1-nested-rtxns-6 version. This version is experimental and will not be maintained in this state until we merge the changes into upstream LMDB. For the time being, we will continue to maintain it in this manner.