Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meilisearch-js dependency verison (v0.44) #1327

Merged
merged 17 commits into from
Oct 7, 2024

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Oct 6, 2024

Copy link

changeset-bot bot commented Oct 6, 2024

🦋 Changeset detected

Latest commit: 681e38f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@meilisearch/instant-meilisearch Minor
eslint-config-meilisearch Patch
@meilisearch/autocomplete-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@curquiza curquiza marked this pull request as draft October 6, 2024 16:40
@curquiza
Copy link
Member Author

curquiza commented Oct 6, 2024

@flevi29 sorry I don't have that much time, but I can spend more time next week. If you have time in the meantime, can you help me upgrade the version of meilisearch-js correctly in instant-meilisearch, please? 😊

Feel free to add commit to this branch of course

@flevi29
Copy link
Collaborator

flevi29 commented Oct 6, 2024

@curquiza I'll do it tomorrow.

@flevi29
Copy link
Collaborator

flevi29 commented Oct 7, 2024

Okay, now it passes, I'm going to add changeset and description a little later.

flevi29
flevi29 previously approved these changes Oct 7, 2024
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curquiza I think now it's good to go.

@flevi29 flevi29 marked this pull request as ready for review October 7, 2024 10:50
flevi29
flevi29 previously approved these changes Oct 7, 2024
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now it LGTM for real.

@curquiza
Copy link
Member Author

curquiza commented Oct 7, 2024

Thank you very much @flevi29 ❤️

bors merge

@meili-bors meili-bors bot merged commit 8378c28 into main Oct 7, 2024
7 checks passed
@meili-bors meili-bors bot deleted the update-meilisearch-js branch October 7, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants