Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code samples v1.4 #1579

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Code samples v1.4 #1579

merged 1 commit into from
Sep 20, 2023

Conversation

curquiza
Copy link
Member

@curquiza curquiza changed the base branch from main to bump-meilisearch-v1.4.0 September 18, 2023 12:15
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Sep 18, 2023
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🦕

bors merge

meili-bors bot added a commit that referenced this pull request Sep 20, 2023
1579: Code samples v1.4 r=mdubus a=curquiza

Related to meilisearch/documentation#2556

Co-authored-by: curquiza <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 20, 2023

Build failed:

@mdubus
Copy link
Member

mdubus commented Sep 20, 2023

bors merge

meili-bors bot added a commit that referenced this pull request Sep 20, 2023
1579: Code samples v1.4 r=mdubus a=curquiza

Related to meilisearch/documentation#2556

Co-authored-by: curquiza <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 20, 2023

Build failed:

@curquiza
Copy link
Member Author

@mdubus we have to merge manually because the the tests are done with the latest of Meilisearch (v1.3.X) and we want to merge on bump-meilisearch-v1.4.0 which has their tests updated for v1.4.0, so it cannot work 😊

@curquiza curquiza merged commit dd8757a into bump-meilisearch-v1.4.0 Sep 20, 2023
7 checks passed
@curquiza curquiza deleted the code-samples-v1.4 branch September 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants