Add parameter to get tasks in reverse order #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
norkunas
reviewed
Dec 4, 2024
norkunas
reviewed
Dec 4, 2024
norkunas
reviewed
Dec 4, 2024
|
Hello @norkunas and thanks for the early review 👋 I forgot to set the PR as a draft. I applied all your suggestions. Thanks! We're now ready for a new review. It looks like the test is flaky though, because it failed at first; and worked when I re-ran it. I'm not sure how I can make it better. If you have feedback, it's welcome. |
Hey 👋
Which tasks does it retrieve? Because I don't see that index would be seeded? |
|
Oh looks like that after each test the index is not cleared, so it sees previous tests data 😑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #693
Thank you so much for contributing to Meilisearch!