-
Notifications
You must be signed in to change notification settings - Fork 99
Serialize for MultiSearchResponse #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Serialize for MultiSearchResponse #668
Conversation
WalkthroughThe update adds the Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
What does this PR do?
This adds
serde::Serialize
toMultiSearchResponse
.I'm in a situation where I proxy requests between client and Meilisearch. During which I have authentication via OAuth and although client has logic in place, I want to inspect responses from Meilisearch and ensure the authenticated user is only getting data they are authorized for given group associations, whether indices or specific records in other index hits.
The knee-jerk suggestion is to use different API keys. However, we have indices where for different users they have different permissions on what they can see and it's just not feasible/practical to duplicate indices/records into every combination of access rights.
PR checklist
Please check if your PR fulfills the following requirements:
Summary by CodeRabbit