Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LiquibaseLoaderIntegrationTest #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mogoodrich
Copy link
Contributor

@mogoodrich mogoodrich commented Sep 27, 2022

I noticed when running tests that the LiquibaseLoaderIntegrationTest was failing for me when running all the tests via Maven. Looking at the test, I saw a comment and some code ignoring when running github actions.

I think I figured out the error: the DeleteDomainChecksumsChangesetIntegrationTest was polluting the context somehow, and so if it happened to run before the LiquibaseLoaderIntegrationTest the latter fails.

I was able to fix it by changing the name the liquibase files used (see PR) though the "proper" fix would likely be to fix the DeleteDomain test to clean up it's context.

fyi @ibacher

@mogoodrich
Copy link
Contributor Author

mogoodrich commented Sep 27, 2022

But now github actions is failing on this test:
"load_shouldLoadFormWithAllAttributesSpecified(org.openmrs.module.initializer.api.form.HtmlFormsLoaderIntegrationTest)"
... but I'm not seeing this locally... so this may not help things... @ibacher @mks-d I'm happy to just close this out without merging, but worth you taking a look at it first to see if it's helpful at all.

@mseaton mseaton requested a review from ibacher September 28, 2022 00:00
@mks-d mks-d changed the title Fix Liquibase Loader Test Fix LiquibaseLoaderIntegrationTest Jun 28, 2024
Copy link
Member

@mks-d mks-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mogoodrich is this still current?

@mekomsolutions mekomsolutions deleted a comment from mogoodrich Jul 1, 2024
@mks-d mks-d removed the request for review from ibacher July 1, 2024 14:21
@ibacher
Copy link
Member

ibacher commented Jul 1, 2024

Looks like this is still necessary (i.e., we're skipping this test on GH Actions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants