Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #263

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix spelling #263

merged 1 commit into from
Jun 8, 2023

Conversation

laquazi
Copy link
Contributor

@laquazi laquazi commented Jun 8, 2023

Fixed some spelling mistakes in comments/docs and internal code.
Also consider changing these:

  • SysExIncompleted (to SysExIncomplete)
  • SysExCompleted (to SysExComplete)
  • NOTPERMITTED (to FORBIDDEN)
  • Lengthed
    Not mistakes, but they sound rather unnatural.

@melanchall
Copy link
Owner

Hi @laquazi,

Thanks for the PR!

As for suggestions:

  • Not permitted - used by official Core MIDI documentation so I think it's better to stick with it.
  • Lengthed - I understand, super strange word, but... maybe you can give me a hint: how to say that something has a length? One word, adjective is preferred. Also this word unfortunately is pretty old within the library and thus renaming will cause breaking changes :(

As for SysExIncompleted/SysExCompleted, thank you, I'll fix them.

@melanchall melanchall added this to To do in DryWetMIDI via automation Jun 8, 2023
@melanchall melanchall added this to the 7.0.0 milestone Jun 8, 2023
@melanchall melanchall moved this from To do to In progress in DryWetMIDI Jun 8, 2023
@melanchall melanchall merged commit 73fad29 into melanchall:develop Jun 8, 2023
59 of 63 checks passed
DryWetMIDI automation moved this from In progress to Done Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
DryWetMIDI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants