Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: allow_extra_fields #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jchavarri
Copy link
Member

Adds docs for json.allow_extra_fields.

@andreypopp
Copy link
Collaborator

The only catch is that json.allow_extra_fields is the default for browser ppx — we don't check for extra fields there. 😬

@jchavarri
Copy link
Member Author

Ah, interesting! Would it make sense to consolidate? If we do so, maybe we can make ignoring extra fields the default on both native and js, and add a decorator @json.strict. I think that allowing extra fields is a more common use case. Wdyt?

@andreypopp
Copy link
Collaborator

Sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants