-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Visitor Counter Block. #14
base: master
Are you sure you want to change the base?
Conversation
What do you think about one of these for the block icon? https://material.io/tools/icons/?icon=trending_up&style=outline Also — any chance we can vertically center the numbers within the container? |
Thank you for the suggestions, @melchoyce! I used the While I was there, I added faded background digits, in the style of a digital clock. This did mean that I had to place each digit in its own I've updated the screenshots in the description to match these changes. |
It occurred to me that there might be a I left the screen reader text, as this is still a better option for screen readers than just the number: it provides context that sighted users gain from the visual styling. |
I'm not wild about the wording of the Padding Digits help text (or the name, "Padding Digits", for that matter). They feel like they were written by a programmer. 😉 |
Looking good. I'm not totally sure what "padding digits" does — just inflate the size? |
Does this need to be a setting, or can we just pick a random number of 0s? |
It doesn't need to be a setting, it previously had a default of 8: I added the setting to see what it looked like, I'm fine with removing it, too. 🙂 |
Let's nix it 👍 |
Description
Fixes #1.
This PR is based on this earlier effort: WordPress/gutenberg@4426159
Additionally, it adds the following features:
8
behind each digit, giving the appearance of an unlit LED digit.Screenshots