Bug Fixed - inheritance check in resource check #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 129307b.
When resources are referenced by the entry point functions, they will miss resources that are declared inside base classes. This has been fixed in this commit.
Any shader set that is defined solely based on the VertexShader and FragmentShader attributes was being missed .This will find that 'set' and allow compilation to continue.
|
My Git knowledge seems to have failed me. I have also rolled a second bug fix into this pull request somehow. The second fix enables the ability for the shader set to be automatically generated with just a VertexShader and FragmentShader. There was logic in there, but it was stale. |
And updated the CSharp CodeAnalysis to V 3.7
Temporary change to flush a bug.
|
Yay! Light is green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the main entry points are checked for resource usage, they only check for containment in the current class. I added a simple fix to walk up the inheritance tree to find a match
there may be better ways to do this, feel free to re-write, but this technically fixes it.