Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress on scatter plot, need review on plot refreshing #11

Merged
merged 5 commits into from
Apr 4, 2024
Merged

progress on scatter plot, need review on plot refreshing #11

merged 5 commits into from
Apr 4, 2024

Conversation

josenimo
Copy link
Collaborator

@josenimo josenimo commented Apr 4, 2024

No description provided.

@josenimo josenimo requested a review from melonora April 4, 2024 07:13
melonora
melonora requested changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@melonora melonora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the plot is not updating because you don't have a proper updating function. You are not clearing the canvas of the plot in between marker / y axis changes.

src/cell_gater/widgets/scatter_widget.py Outdated Show resolved Hide resolved
src/cell_gater/widgets/scatter_widget.py Outdated Show resolved Hide resolved
josenimo and others added 2 commits April 4, 2024 10:33
@josenimo josenimo merged commit 8e909b0 into melonora:main Apr 4, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melonora melonora melonora requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josenimo @melonora