Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge request of a recipe gemini-code-completion #9108

Closed
wants to merge 7 commits into from

Conversation

shishimaru
Copy link
Contributor

Brief summary of what the package does

This package inserts source code generated with Google Gemini by sending parts of code opened in current buffer.

Direct link to the package repository

https://github.com/shishimaru/gemini-code-completion.el

Your association with the package

I am a maintainer of this package.

Relevant communications with the upstream package maintainer

On this pull request.

Checklist

@riscy
Copy link
Member

riscy commented Jul 14, 2024

Thanks for this. This PR modifies two recipe files - could you exclude the helm-find-project-files recipe?

In the meantime, re: [gemin-code-completion] it appears it has a dependency (google-gemini) that is not installable -

gemini-code-completion.el with byte-compile using Emacs 29.4:

gemini-code-completion.el:30:2: Error: Cannot open load file: No such file or directory, google-gemini

gemini-code-completion.el with package-lint 20240507.1722:

1 issue found:
7:23: error: Package google-gemini is not installable.

#'load-check on each file:

Loading gemini-code-completion.el
  gemini-code-completion.el:Error: Emacs 29.4:
  (file-missing "Cannot open load file" "No such file or directory" "google-gemini")

@shishimaru
Copy link
Contributor Author

shishimaru commented Jul 15, 2024

Thanks for this. This PR modifies two recipe files - could you exclude the helm-find-project-files recipe?

Oh, sorry, it is my old recipe and not needed in this package.

In the meantime, re: [gemin-code-completion] it appears it has a dependency (google-gemini) that is not installable -

It is a dependent package distributed via JCS ELPA, not Melpa.
https://github.com/emacs-openai/google-gemini

I want to get your advice, how should I describe the dependency in the header of my code gemini-code-completion.el ?
Or do I have to handle this issue with another method such as including the dependent package as Git submodule on my Git repository ?

@tarsius
Copy link
Member

tarsius commented Jul 16, 2024

It is a dependent package distributed via JCS ELPA, not Melpa.

It is gemini-code-completion which depends on google-gemini. (Replace "dependent package" with "dependency" in your sentence, for the meaning you intended.)

Melpa only distributes packages whose dependencies are part of Emacs or are being distributed on GNU Elpa, NonGNU Elpa or Melpa itself. So you will have to ask the maintainer of JCS ELPA, if he is willing to distribute your package there.

@tarsius
Copy link
Member

tarsius commented Aug 7, 2024

Closing since the author will to open a new pr when he is ready (as per emacs-openai/google-gemini#2).

@tarsius tarsius closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants