fix(targets): Log sink when an unhandled error occurs during setup

meltano · Dec 18, 2023 · 69948a3 · 69948a3
1 parent 544f61f
commit 69948a3
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/singer_sdk/target_base.py b/singer_sdk/target_base.py
@@ -239,6 +239,9 @@ def add_sink(
 
         Returns:
             A new sink for the stream.
+
+        Raises:
+            Exception: If sink setup fails.
         """
         self.logger.info("Initializing '%s' target sink...", self.name)
         sink_class = self.get_sink_class(stream_name=stream_name)
@@ -248,7 +251,13 @@ def add_sink(
             schema=schema,
             key_properties=key_properties,
         )
-        sink.setup()
+
+        try:
+            sink.setup()
+        except Exception:
+            self.logger.exception("Error initializing '%s' target sink", self.name)
+            raise
+
         self._sinks_active[stream_name] = sink
         return sink