Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: set ff.env_var_strict_mode to true #312

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data/.env.template
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Developer Prefix
USER_PREFIX=PNADOLNY

# Google Analytics Tap
TAP_GOOGLE_ANALYTICS_CLIENT_SECRETS="{\"type\": \"service_account\",\"project_id\": \"foo\",\"private_key_id\": \"bar\",\"private_key\": \"-----BEGIN PRIVATE KEY-----\\nfoo\\nbar\\n-----END PRIVATE KEY-----\\n\",\"client_email\": \"[email protected]\",\"client_id\": \"foo\",\"auth_uri\": \"https://accounts.google.com/o/oauth2/auth\",\"token_uri\": \"https://oauth2.googleapis.com/token\",\"auth_provider_x509_cert_url\": \"https://www.googleapis.com/oauth2/v1/certs\",\"client_x509_cert_url\": \"https://www.googleapis.com/robot/v1/metadata/x509/foobar.iam.gserviceaccount.com\"}"

Expand All @@ -17,8 +20,5 @@ PERMISSION_BOT_ACCOUNT="****"
# Snowflake MELTANO User Password
SNOWFLAKE_PASSWORD="****"

# dbt Snowflake Password
DBT_SNOWFLAKE_PASSWORD="****"

# Slack Webhook
TARGET_APPRISE_URIS=["https://hooks.slack.com/services/{}/{}/{}"]
1 change: 0 additions & 1 deletion data/environments/userdev.meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ environments:
role: ${USER_PREFIX}
warehouse: CORE
env:
USER_PREFIX: PNADOLNY
HUB_METRICS_S3_PATH: s3://devtest-meltano-bucket-01/hub_metrics/
SUPERSET_API_URL: http://localhost:8088
SUPERSET_USER: admin
Expand Down
5 changes: 5 additions & 0 deletions data/meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,15 @@ version: 1
default_environment: userdev
send_anonymous_usage_stats: false
project_id: c15e971a-d318-4a9d-979b-1039ce5fd1b1

include_paths:
- ./environments/*.meltano.yml
- ./extract/*.meltano.yml
- ./load/*.meltano.yml
- ./orchestrate/*.meltano.yml
- ./transform/*.meltano.yml
- ./utilities/*.meltano.yml

# Feature Flags - https://docs.meltano.com/reference/settings#feature-flags
# fail if any referenced env vars are missing
ff.strict_env_var_mode: true
10 changes: 5 additions & 5 deletions data/transform/profiles/snowflake/profiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ meltano:
threads: 2
account: "{{ env_var('DBT_SNOWFLAKE_ACCOUNT') }}"
user: "{{ env_var('DBT_SNOWFLAKE_USER') }}"
password: "{{ env_var('SNOWFLAKE_PASSWORD') }}"
password: "{{ env_var('DBT_SNOWFLAKE_PASSWORD') }}"
role: "{{ env_var('DBT_SNOWFLAKE_ROLE') }}"
warehouse: "{{ env_var('DBT_SNOWFLAKE_WAREHOUSE') }}"
database: "{{ env_var('DBT_SNOWFLAKE_DATABASE') }}"
Expand All @@ -23,7 +23,7 @@ meltano:
threads: 2
account: "{{ env_var('DBT_SNOWFLAKE_ACCOUNT') }}"
user: "{{ env_var('DBT_SNOWFLAKE_USER') }}"
password: "{{ env_var('SNOWFLAKE_PASSWORD') }}"
password: "{{ env_var('DBT_SNOWFLAKE_PASSWORD') }}"
role: "{{ env_var('DBT_SNOWFLAKE_ROLE') }}"
warehouse: "{{ env_var('DBT_SNOWFLAKE_WAREHOUSE') }}"
database: "{{ env_var('DBT_SNOWFLAKE_DATABASE') }}"
Expand All @@ -33,7 +33,7 @@ meltano:
threads: 4
account: "{{ env_var('DBT_SNOWFLAKE_ACCOUNT') }}"
user: "{{ env_var('DBT_SNOWFLAKE_USER') }}"
password: "{{ env_var('SNOWFLAKE_PASSWORD') }}"
password: "{{ env_var('DBT_SNOWFLAKE_PASSWORD') }}"
role: "{{ env_var('DBT_SNOWFLAKE_ROLE') }}"
warehouse: "{{ env_var('DBT_SNOWFLAKE_WAREHOUSE') }}"
database: "{{ env_var('DBT_SNOWFLAKE_DATABASE') }}"
Expand All @@ -43,7 +43,7 @@ meltano:
threads: 6
account: "{{ env_var('DBT_SNOWFLAKE_ACCOUNT') }}"
user: "{{ env_var('DBT_SNOWFLAKE_USER') }}"
password: "{{ env_var('SNOWFLAKE_PASSWORD') }}"
password: "{{ env_var('DBT_SNOWFLAKE_PASSWORD') }}"
role: "{{ env_var('DBT_SNOWFLAKE_ROLE') }}"
warehouse: "{{ env_var('DBT_SNOWFLAKE_WAREHOUSE') }}"
database: "{{ env_var('DBT_SNOWFLAKE_DATABASE') }}"
Expand All @@ -53,7 +53,7 @@ meltano:
threads: 4
account: "{{ env_var('DBT_SNOWFLAKE_ACCOUNT') }}"
user: "{{ env_var('DBT_SNOWFLAKE_USER') }}"
password: "{{ env_var('SNOWFLAKE_PASSWORD') }}"
password: "{{ env_var('DBT_SNOWFLAKE_PASSWORD') }}"
role: "{{ env_var('DBT_SNOWFLAKE_ROLE') }}"
warehouse: "{{ env_var('DBT_SNOWFLAKE_WAREHOUSE') }}"
database: "{{ env_var('DBT_SNOWFLAKE_DATABASE') }}"
Expand Down
1 change: 1 addition & 0 deletions data/transform/transformers.meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,4 @@ plugins:
account: epa06486
database_raw: RAW
database_prep: PREP
password: ${SNOWFLAKE_PASSWORD}
3 changes: 3 additions & 0 deletions data/utilities/utilities.meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ plugins:
settings:
- name: user
env: DBT_SNOWFLAKE_USER
- name: password
env: DBT_SNOWFLAKE_PASSWORD
- name: role
env: DBT_SNOWFLAKE_ROLE
- name: database
Expand All @@ -26,6 +28,7 @@ plugins:
account: epa06486
role: TRANSFORMER
warehouse: CORE
password: ${SNOWFLAKE_PASSWORD}
- name: awscli
namespace: awscli
pip_url: awscli==1.21.7
Expand Down