Change setup_incomplete? to setup_completed? in codebase #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wende
commented
Feb 21, 2025
| @@ -69,7 +69,7 @@ defmodule Membrane.Core.Bin.State do | |||
| synchronization: nil, | |||
| initialized?: false, | |||
| terminating?: false, | |||
| setup_incomplete?: false, | |||
| setup_completed?: false, | |||
There was a problem hiding this comment.
Why is incomplete: false a default value for a new structure?
There was a problem hiding this comment.
I guess it might be used as a flag indicating if action setup: :incomplete has been returned from handle_setup
There was a problem hiding this comment.
If I am wrong, then this flag would mean almost this same as :playback
There was a problem hiding this comment.
Now I think that if I am right, maybe we could rename this flag to something less confusing (eg. setup_incomplete_returned??), but there is no sense in renaming it to setup_completed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #937