Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules, dockerize building and testing and stop using self hosted machines #518

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

imilinovic
Copy link
Collaborator

@imilinovic imilinovic commented Oct 3, 2024

Description

Making query modules removed under v1.14.1 available again.

TODOs

  • Put the modules back
  • Move all tests from host to Docker under reusable_test.yml
  • Make sure the release pipeline is also working (don't mess with promotion from RC to release yet)

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@gitbuda
Copy link
Member

gitbuda commented Oct 4, 2024

Removal happened under #443 under Dockerfile.release -> starting from memgraph v2.21, the modules should start working (fix done under memgraph/memgraph#2347) -> revert the change done under v1.14.1 of Mage 😄

@imilinovic imilinovic added Docs needed Docs needed bug bug labels Oct 10, 2024
@imilinovic imilinovic added this to the 1.21.0 milestone Oct 10, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@imilinovic imilinovic changed the title Bring back removed modules Update modules, dockerize building and testing and stop using self hosted machines Nov 22, 2024
@imilinovic imilinovic added infrastructure Docs unnecessary Docs unnecessary and removed Docs needed Docs needed bug bug labels Nov 25, 2024
@gitbuda gitbuda removed this from the 1.21.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants