-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mattb325:industrial-collection
#47
Draft
sebamarynissen
wants to merge
35
commits into
memo33:main
Choose a base branch
from
sebamarynissen:feature/industrial-pack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add mattb325:industrial-collection
#47
sebamarynissen
wants to merge
35
commits into
memo33:main
from
sebamarynissen:feature/industrial-pack
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebamarynissen
force-pushed
the
feature/industrial-pack
branch
from
November 21, 2024 22:18
83d22ec
to
8b7f838
Compare
* Add `sfbt:railway-props` * Rename railwya props again * Add `sfbt:rambuckel-horse-props` * Add `sfbt:royal-light-signal-props` * Add `sfbt:royal-semaphore-signals-props` * Add `sfbt:sam-johnson-playground-props` * Add `sfbt:peterycristi-props` * remove trailing whitespace * shorten package name, fix typos * remove `catid` parameter from URLs --------- Co-authored-by: memo <[email protected]>
…t-pack` (memo33#41) * Add `mattb325:residential-houses` * Remove duplicate hotondo homes The hotondo homes were apparently also hosted on Simtropolis and hence they have been included in the channel already. Removed them from this contribution. * Add `mattb325:multi-unit-pack` (#3) * Figure out dependencies for multi-units * Update residential-multi-units.yaml * Add climate variants to Casa de Manana * Add entire pack * Fix inclusion pattern for R$ terraces * Fix discrepancy between MN and DN folder structure * Fix name of l-aquila-apartments * Fix potential conflict * Fix naming convention * Add pack images * Add Simtropolis images where possible * Link to Simtropolis where possible * Scaffold industrial pack * Revert "Scaffold industrial pack" This reverts commit 5b80f32. * Update residential-houses.yaml * Rename residential-houses-collection * Update name to collection * Rename to residential-multi-unit-collection * Remove catid from url * Make inclusion patterns more robust * Make inclusion patterns more robust
sebamarynissen
force-pushed
the
feature/industrial-pack
branch
from
November 21, 2024 22:19
8b7f838
to
242da8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mattb325's industrial collection.
Just like in #46, the spar distribution center was referencing the wrong desc file, so I've used the Simtropolis asset again for this, which is why I had to rebase on top of #46.
The mail distribution center seems to miss a model file. I've verified that it's also like that when installing the files from SC4E directly without using sc4pac, so. I wasn't able to find a model on Simtropolis, so I commented it out for now and I will get in touch with the SC4E admins.