Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mattb325:industrial-collection #47

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

sebamarynissen
Copy link
Contributor

This PR adds mattb325's industrial collection.

Just like in #46, the spar distribution center was referencing the wrong desc file, so I've used the Simtropolis asset again for this, which is why I had to rebase on top of #46.

The mail distribution center seems to miss a model file. I've verified that it's also like that when installing the files from SC4E directly without using sc4pac, so. I wasn't able to find a model on Simtropolis, so I commented it out for now and I will get in touch with the SC4E admins.

image

image

image

@sebamarynissen sebamarynissen force-pushed the feature/industrial-pack branch from 83d22ec to 8b7f838 Compare November 21, 2024 22:18
sebamarynissen and others added 8 commits November 21, 2024 23:19
* Add `sfbt:railway-props`

* Rename railwya props again

* Add `sfbt:rambuckel-horse-props`

* Add `sfbt:royal-light-signal-props`

* Add `sfbt:royal-semaphore-signals-props`

* Add `sfbt:sam-johnson-playground-props`

* Add `sfbt:peterycristi-props`

* remove trailing whitespace

* shorten package name, fix typos

* remove `catid` parameter from URLs

---------

Co-authored-by: memo <[email protected]>
…t-pack` (memo33#41)

* Add `mattb325:residential-houses`

* Remove duplicate hotondo homes

The hotondo homes were apparently also hosted on Simtropolis and hence they have been included in the channel already. Removed them from this contribution.

* Add `mattb325:multi-unit-pack` (#3)

* Figure out dependencies for multi-units

* Update residential-multi-units.yaml

* Add climate variants to Casa de Manana

* Add entire pack

* Fix inclusion pattern for R$ terraces

* Fix discrepancy between MN and DN folder structure

* Fix name of l-aquila-apartments

* Fix potential conflict

* Fix naming convention

* Add pack images

* Add Simtropolis images where possible

* Link to Simtropolis where possible

* Scaffold industrial pack

* Revert "Scaffold industrial pack"

This reverts commit 5b80f32.

* Update residential-houses.yaml

* Rename residential-houses-collection

* Update name to collection

* Rename to residential-multi-unit-collection

* Remove catid from url

* Make inclusion patterns more robust

* Make inclusion patterns more robust
@sebamarynissen sebamarynissen force-pushed the feature/industrial-pack branch from 8b7f838 to 242da8c Compare November 21, 2024 22:19
@sebamarynissen sebamarynissen marked this pull request as draft December 29, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant