Add truck stops #48
Add truck stops #48
Conversation
Note: two dependencies are not listed on ST: `peg:mtp-super-pack` and `bsc:textures-vol01`
|
Apparently the only dependency missing was |
I'm not sure having the default channel depend on other channels is a good idea... It is expected to remain maintained as long as sc4pac is, but other channels have no garantee on that. The default channel should be complete in itself. |
|
@Zasco Yes I agree, that's why I added the missing package in this PR as well. Once it gets merged, you can deleted it from your channel. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
By the way, I'm going to try to review your PRs in a few days. |
|
Take your time, there's no rush from my side. Just know that my scraping scripts are now in a state that very little manual intervention is still needed, even for the descriptions and dependencies, so you'll probably see some more PRs coming in from me in the following days. :) Btw, I'll create a separate issue to discuss the exchange-specific channels. If you could move your comment to that issue, then I'll reply to it there. Keeps this PR clean. |
There was a problem hiding this comment.
@sebamarynissen thoughts about changing w-swietwoot:dutch-prop-pack → bnl:dutch-prop-pack as it was released under the BNL team banner?
There was a problem hiding this comment.
@noah-severyn That makes sense I guess. It's not always clear to me whether a package should be put under the author's name or under the team name. Do you have any guidelines for this @memo33 ?
There was a problem hiding this comment.
@noah-severyn That makes sense I guess. It's not always clear to me whether a package should be put under the author's name or under the team name. Do you have any guidelines for this @memo33 ?
I have a preference for the team name if either the title, images, or description makes reference to the team name. IMO it's a good way to group similar content as groups tend to have a "theme" so it could make a quick thing to search for if you find one piece of content you like. Plus, I just personally kind of enjoy the history. :P
There was a problem hiding this comment.
Do you have any guidelines for this @memo33 ?
Not really. I mostly go by intuition, what's more recognizable and what's used in other uploads. In the end, it's a question of what makes the package easy to find or identify. To that end, if an author name or some essential acronym is not part of the group or package name, it can be included in the summary, so it can be found via search.
There was a problem hiding this comment.
Allright, I'll put the dutch prop pack under bnl flag then. I guess especially for prop packs it makes sense to release them under the team name, as props released under a team name are probably used by various batters of that team.
|
@memo33 ready for review |
|
Thanks. I chose to merge the two RHD/LHD Esso station packages into a single package using
I'm open to this idea. For now, using 100-props-textures should be fine. The main question we need to ask ourselves is whether this distinction is understandable and useful for end users. |
|
Definitely makes sense indeed if the NAM doesn't have those ramps available. |
This PR adds a bunch of truck stops.
I've had to split up a lot of packages in resources and lot parts because the American Truck Stop has an insane amount of dependencies. I was thinking that maybe this kind deserves a separate subfolder category, like 110-shared-resources or something because 100-props-textures doesn't cover the purpose. For now I've put all these resource packages under 100-props-textures.
This PR also relies on a few dependencies that @Zasco has added in his own channel. I'll let the GitHub action fail and have it find out which ones I still need to copy over.